Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgl-gl-error-check fails on ArrayBuffers passed to bufferData #1

Closed
bhouston opened this issue Jul 18, 2020 · 2 comments
Closed

webgl-gl-error-check fails on ArrayBuffers passed to bufferData #1

bhouston opened this issue Jul 18, 2020 · 2 comments

Comments

@bhouston
Copy link

The code seems to make an assumption typed arrays are always passed in.

Screenshot from 2020-07-18 13-13-00

Because it assumes src.buffer exists. But on ArrayBuffer and ArrayBufferView it doesn't per the spec:

https://developer.mozilla.org/en-US/docs/Web/API/ArrayBufferView
https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/bufferData

@greggman
Copy link
Owner

Thanks for the report. Fixed.

Just FYI though. MDN is NOT the spec. MDN is a user edited wiki and is often wrong.

@bhouston
Copy link
Author

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants