Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing tests in parallel would be impaired by synchronized block in Spectrum #67

Closed
ashleyfrieze opened this issue Nov 30, 2016 · 2 comments

Comments

@ashleyfrieze
Copy link
Contributor

In a situation where something like JUnit's ParallelComputer were used, or where other test runners were parallelising the construction of test classes run with the Spectrum runner, the fact that the test class construction happens inside a synchronized block will constrain the execution time.

This is relatively easy to fix. It's in a synchronized block to protect a stack from being bombarded by different threads. By introducing a thread-independent singleton into the mix, this will become thread-safe. This is what I propose to do.

@ashleyfrieze
Copy link
Contributor Author

@greghaskins - this was resolved by #77

@ashleyfrieze
Copy link
Contributor Author

I'm going to close this, since it's a detail, rather than an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant