aroundAll runs even when all specs are ignored

[greghaskins]

This is a low-priority one, but should probably get addressed at some point. At the moment, there isn't a simple implementation fix, because Suite objects don't know which of their children are ignored or not. I think the underlying implementation will evolve to be based more around tags anyway; fixing this issue will be simpler after that.

For reference, this is the failing test:

describe("a suite with only ignored specs", () -> {

  it("should not run aroundAll", () -> {
    ArrayList<String> steps = new ArrayList<>();
    SpectrumHelper.run(() -> {

      aroundAll(block -> {
        steps.add("aroundAll");
        block.run();
      });

      xit("foo", () -> {
      });

    });

    assertThat(steps, is(empty()));
  });

});

[ashleyfrieze]

The suite should be able to tell if its children are ignored. The question is, I guess, whether it needs to be testing for ignored of direct descendants, or the whole tree.

Just add isIgnored to Child and then

// suite
boolean areChildrenIgnored() {
    return children.stream().filter(child -> !child.isIgnored()).findFirst().isPresent();
}

[ashleyfrieze]

This will be fixed by #56 which would otherwise be doing big class-rule things with totally ignored suites.

[greghaskins]

@ashleyfrieze we should check if this bug still applies, or whether it was fixed by #56 .

[ashleyfrieze]

I think this may have been fixed by #56

      describe("a suite with only ignored specs", () -> {

        it("should not run aroundAll", () -> {
          ArrayList<String> steps = new ArrayList<>();
          SpectrumHelper.run(() -> {

            aroundAll(block -> {
              steps.add("aroundAll");
              block.run();
            });

            xit("foo", () -> {
            });

          });

          assertThat(steps, is(empty()));
        });

      });

That passes - it's a test within a test. The SpectrumHelper.run wraps the real block with both ignored and aroundAll. The effect of running this is that the array list remains empty, so the hook didn't run.

I wonder if I stole this test from somewhere and made it pass while making the hooks work for JUnit mixins. I can't remember.

[greghaskins]

Resolved by #56.