Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagged-literal warnings with Clojure 1.7.0-beta1 #20

Closed
xpe opened this issue Apr 23, 2015 · 3 comments
Closed

tagged-literal warnings with Clojure 1.7.0-beta1 #20

xpe opened this issue Apr 23, 2015 · 3 comments
Assignees

Comments

@xpe
Copy link

xpe commented Apr 23, 2015

I use ultra. I get these warnings with [mvxcvi/puget "0.7.1"] with [org.clojure/clojure "1.7.0-beta1"]:

WARNING: tagged-literal already refers to: #'clojure.core/tagged-literal in namespace: puget.data, being replaced by: #'puget.data/tagged-literal
WARNING: tagged-literal? already refers to: #'clojure.core/tagged-literal? in namespace: puget.data, being replaced by: #'puget.data/tagged-literal?
@greglook greglook self-assigned this Apr 25, 2015
@greglook
Copy link
Owner

Yeah, this needs to be updated for Puget to use the built-in tagged-literal code in 1.7.

@xpe
Copy link
Author

xpe commented Apr 25, 2015

I took a look at the code -- it didn't like a trivial change (at least for me to knock out quickly).

@greglook
Copy link
Owner

@xpe see the referenced commit - this code wasn't actually being used much. Once 1.7 is stable I should extend the ExtendedNotation protocol to the built-in TaggedLiteral type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants