Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer dependency react to v17 #1660

Closed
ghost opened this issue Feb 16, 2021 · 4 comments
Closed

Update peer dependency react to v17 #1660

ghost opened this issue Feb 16, 2021 · 4 comments

Comments

@ghost
Copy link

ghost commented Feb 16, 2021

Expected Behavior

get errors on installation mui-datatables on node >= v15
cannot resolve peer dependencies, namely react

Current Behavior

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: mui-datatables-print-test@1.0.0
npm ERR! Found: react@17.0.1
npm ERR! node_modules/react
npm ERR!   peer react@"^16.8.0 || ^17.0.0" from @material-ui/core@4.11.3
npm ERR!   node_modules/@material-ui/core
npm ERR!     peer @material-ui/core@"^4.0.0" from mui-datatables@3.7.6
npm ERR!     node_modules/mui-datatables
npm ERR!       mui-datatables@"*" from the root project
npm ERR!     peer @material-ui/core@"^4.0.0" from @material-ui/icons@4.11.2
npm ERR!     node_modules/@material-ui/icons
npm ERR!       peer @material-ui/icons@"^4.0.0" from mui-datatables@3.7.6
npm ERR!       node_modules/mui-datatables
npm ERR!         mui-datatables@"*" from the root project
npm ERR!   peer react@"17.0.1" from react-dom@17.0.1
npm ERR!   node_modules/react-dom
npm ERR!     peer react-dom@"^16.8.0 || ^17.0.0" from @material-ui/core@4.11.3
npm ERR!     node_modules/@material-ui/core
npm ERR!       peer @material-ui/core@"^4.0.0" from mui-datatables@3.7.6
npm ERR!       node_modules/mui-datatables
npm ERR!         mui-datatables@"*" from the root project
npm ERR!       1 more (@material-ui/icons)
npm ERR!     peer react-dom@"^16.8.0 || ^17.0.0" from @material-ui/icons@4.11.2
npm ERR!     node_modules/@material-ui/icons
npm ERR!       peer @material-ui/icons@"^4.0.0" from mui-datatables@3.7.6
npm ERR!       node_modules/mui-datatables
npm ERR!         mui-datatables@"*" from the root project
npm ERR!   1 more (@material-ui/icons)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from mui-datatables@3.7.6
npm ERR! node_modules/mui-datatables
npm ERR!   mui-datatables@"*" from the root project

Steps to Reproduce (for bugs)

  1. Create empty project
  2. npm i mui-datatables

Your Environment

Tech Version
Material-UI latest
MUI-datatables latest
React latest
browser chrome
etc Linux Ubuntu 16.04
node 15.0.1
@wdh2100
Copy link
Collaborator

wdh2100 commented Feb 19, 2021

Let's test it out and modify the peerDependencies.

    "react": "^16.8.0 || ^17.0.0",
    "react-dom": "^16.8.0 || ^17.0.0"

Perhaps the 16,17 versions are known to be compatible.

@morjanmihail
Copy link

Same issue in July with React 17.0.2. Any new hotfix update for this?

@abdennour
Copy link

abdennour commented Dec 12, 2021

same issue as @morjanmihail 's issue . cannot install it with React 17.0.2

@vinduajamesh
Copy link

dependency still hasn't been updated. can't install this awesome library.

I'm now using React version 18. I think it's still requiring 16 as the compatible React version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants