Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console Log Spam Delays Rendering of Table Data #1873

Closed
busches opened this issue Feb 21, 2022 · 7 comments
Closed

Console Log Spam Delays Rendering of Table Data #1873

busches opened this issue Feb 21, 2022 · 7 comments

Comments

@busches
Copy link

busches commented Feb 21, 2022

Upgrading from 3.8.2 to 3.8.3 results in a lot of Console.log spam:

image

While annoying, this normally wouldn't be a problem, but since the spam is taking so long to output, it's delaying the actual data in the table from loading, which is a problem for users and Cypress tests.

Appears to be directly related to the changes here: #1825

Expected Behavior

No console.log spam

Current Behavior

Lots of console.log spam.

Steps to Reproduce (for bugs)

Happens on any usage of a MUIDataTable from what I can tell.

Example stack trace from the logs:

    console.log
      {
        'data-testid': 'MuiDataTableBodyCell-1-0',
        dataIndex: 0,
        rowIndex: 0,
        colIndex: 1,
        columnHeader: 'Tax Rules Assigned',
        print: true,
        options: {
          caseSensitive: false,
          consoleWarnings: true,
          disableToolbarSelect: false,
          download: true,
          downloadOptions: { filename: 'tableDownload.csv', separator: ',' },
          draggableColumns: { enabled: false, transitionTime: 300 },
          elevation: 4,
          enableNestedDataAccess: '',
          expandableRows: false,
          expandableRowsHeader: true,
          expandableRowsOnClick: false,
          filter: false,
          filterArrayFullMatch: true,
          filterType: 'dropdown',
          fixedHeader: true,
          fixedSelectColumn: true,
          pagination: true,
          print: false,
          resizableColumns: false,
          responsive: 'vertical',
          rowHover: true,
          rowsPerPageOptions: [ 10, 15, 100 ],
          search: true,
          selectableRows: 'none',
          selectableRowsHideCheckboxes: false,
          selectableRowsOnClick: false,
          selectableRowsHeader: true,
          serverSide: false,
          serverSideFilterList: null,
          setTableProps: [Function: setTableProps],
          sort: true,
          sortFilterList: true,
          tableBodyHeight: 'auto',
          tableBodyMaxHeight: null,
          sortOrder: {},
          textLabels: {
            body: [Object],
            pagination: [Object],
            toolbar: [Object],
            filter: [Object],
            viewColumns: [Object],
            selectedRows: [Object]
          },
          viewColumns: false,
          selectToolbarPlacement: 'replace',
          tableId: '049594251753001384',
          title: ''
        },
        tableId: '049594251753001384',
        isEmpty: false,
        children: 2
      }

      at TableBodyCell (node_modules/mui-datatables/src/components/TableBodyCell.js:115:41)

    console.log
      isEmtyfalse

      at TableBodyCell (node_modules/mui-datatables/src/components/TableBodyCell.js:176:18)

Your Environment

Tech Version
Material-UI 4.12.3
MUI-datatables 3.8.3
React 17.0.2
browser Chrome, Firefox, and Electron all had the same issue
etc
@busches busches changed the title Console Log Spam Console Log Spam Delays Rendering of Table Data Feb 21, 2022
@rodrigomercadorynb
Copy link

rodrigomercadorynb commented Mar 3, 2022

Heyy!!

Getting the same error right here..
Any updates on this? 😀

Or.. are we waiting for the new version?

@busches
Copy link
Author

busches commented Mar 3, 2022

Waiting on new version

@mhorger3
Copy link

@wdh2100 do you know when the next target V3 release is tentatively scheduled for?

@wdh2100
Copy link
Collaborator

wdh2100 commented Mar 15, 2022

@rodrigomercadorynb @busches @mhorger3

sorry. I'll release the new version(v3) after work.

@wdh2100
Copy link
Collaborator

wdh2100 commented Mar 15, 2022

fixed 3.8.5

@rodrigomercadorynb
Copy link

fixed 3.8.5

Can confirm it´s fixed!!
Thank youu 😀😀

@busches
Copy link
Author

busches commented Mar 21, 2022

Closing since this was resolved in #1875

@busches busches closed this as completed Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants