Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advice? -- Inline Updates #69

Closed
teadams opened this issue May 25, 2018 · 1 comment
Closed

Advice? -- Inline Updates #69

teadams opened this issue May 25, 2018 · 1 comment
Labels

Comments

@teadams
Copy link
Contributor

teadams commented May 25, 2018

I've used customRender to do inline edits to data in individual cells.

It seems like I have these options for after i call the server

  1. Visually, the value has changed in the table. I can trust that the server updated the data correctly and continue with the same data array.
  2. I can update the state of my data array, which will force a new render of MUIDataTable. All my sorts go away.
  3. If there are errors from the server, I can catch them and diplay a red "The update did not work" on the top of the screen. The screen will still have the new value, but I've given a visual cue to the user that something went wrong.

I'm leaning toward 3, but would like to hear what people think.

@teadams teadams changed the title Need advise -- Inline Updates Advice? -- Inline Updates May 25, 2018
@patorjk
Copy link
Collaborator

patorjk commented Jun 15, 2020

Closing due to age of issue. Problem described in #2 now resolved in later versions of the table (state, including sorting, is no longer reset).

@patorjk patorjk closed this as completed Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants