Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectableRowsOnClick overrides isRowSelectable #764

Closed
pbatleyGH opened this issue Jul 11, 2019 · 2 comments · Fixed by #766
Closed

selectableRowsOnClick overrides isRowSelectable #764

pbatleyGH opened this issue Jul 11, 2019 · 2 comments · Fixed by #766
Assignees
Labels

Comments

@pbatleyGH
Copy link

pbatleyGH commented Jul 11, 2019

Expected Behavior

selectableRowsOnClick seems to override isRowSelectable. A row with isRowSelectable that returns false can still be selected by clicking it. The checkbox appears greyed out suggesting that the isRowSelectable styling is being applied.

I would expect the behaviour to be that a row with isRowSelectable false should not be selectable at all. If isRowSelectable returns true, then the checkbox for selection should work, and if isRowSelectable returns true and selectableRowsOnClick is true then the row should be selectable by clicking anywhere within it.

Current Behavior

(see previous paragraph)

Your Environment

Tech Version
Material-UI 4.2.0
MUI-datatables 2.6.2
React 16.8.6
browser Chrome 74.0.3729.108
@gabrielliwerant
Copy link
Collaborator

Nice find, I can confirm this is a bug. Thank you!

@gabrielliwerant
Copy link
Collaborator

Should be fixed in 2.6.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants