Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with passing CRLF to pulldown_cmark #21

Closed
markbahnman opened this issue Dec 11, 2022 · 2 comments
Closed

Issues with passing CRLF to pulldown_cmark #21

markbahnman opened this issue Dec 11, 2022 · 2 comments

Comments

@markbahnman
Copy link

markbahnman commented Dec 11, 2022

There's an issue when developing on windows with code blocks in a markdown file such as

```
fn foo () {
  "bar";
}
```

Windows seems to send \r\n which pulldown_cmark doesn't handle well (github issue) and ends up inserting an error message into the resultant html. I fixed it for myself here
markbahnman@7a762d5 but there might be a better way to handle it.

@grego
Copy link
Owner

grego commented Dec 11, 2022

Fixed this inside cmark-syntax: grego/cmark-syntax@6439dd7
Available in blades v0.5
Please let me know if it solves the issue.

@markbahnman
Copy link
Author

Yup, that seems to solve it, thanks!

@grego grego closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants