Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add a DESCRIPTION attribute in 'Inp' and 'Set' specifications? #122

Closed
gregorbj opened this issue Jul 28, 2017 · 2 comments
Closed
Assignees

Comments

@gregorbj
Copy link
Owner

The dataset name registry is very useful for cataloging the datasets produces by all 'registered' modules. However, it can be difficult to understand what a dataset is just from the dataset specifications. You have to deduce what it is from the NAME, TABLE, PROHIBIT, UNITS, and ISELEMENTOF attributes. I propose adding a DESCRIPTION attribute which developers use to enter a phrase or sentence describing the nature of the dataset. For example the DESCRIPTION of the 'Income' dataset in the 'Household' table would be: 'Total annual income of all members of the household'. This attribute would be required for all 'Inp' and 'Set' specifications. It would not be required for the 'Get' specifications and would not be checked for consistency of 'Get' specifications with datastore specifications. This attribute would not need to be stored in the datastore because the dataset name registry is created from module specifications, not from attributes saved in the datastore.

@gregorbj
Copy link
Owner Author

Support for DESCRIPTION attribute has been added to the 'storagetest' branch. Specifications will not pass testing unless there are proper DESCRIPTION attributes. This attribute is very important because it enforces documentation of the meaning of each dataset. Because this information is part of the code and is saved in dataset attributes, it greatly improves understanding of modules, what they consume, and what they produce. All modules in the 'storagetest' branch have been modified to include DESCRIPTION attributes and have been tested.

@bstabler
Copy link
Collaborator

bstabler commented Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants