Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous properties (and even class)? #23

Closed
ChrisSimmons opened this issue Apr 7, 2016 · 2 comments
Closed

Extraneous properties (and even class)? #23

ChrisSimmons opened this issue Apr 7, 2016 · 2 comments

Comments

@ChrisSimmons
Copy link
Contributor

I'm curious about a few things:

  • It does not appear that AggregateRoot.Version serves any purpose. While I've seen Version used actively on the aggregate in many examples (books, articles) on ES, in this case it seems extraneous. Is this just serving as an example that a non-trivial real-world app would likely have a Version property on the aggregate?
  • Similarly, it appears that EventStore.EventDescriptor.Id serves no purpose. If you take that as true, EventStore.EventDescriptor as whole seems to have no purpose as it only has Version, which Event already has. Again, is this just an illustration that a real-world ES app would have a "wrapper" like this around Event? I know that NEventStore has the EventMessage class that serves as a similar wrapper concept.
@gregoryyoung
Copy link
Owner

Version is not used in this code though many have taken the aggregate base and used it (which is why its there)
EventDescriptor is more internals of what an eventstore would do internally EG it can treat event as a vector of byte and only use descriptor

@ChrisSimmons
Copy link
Contributor Author

Got it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants