Skip to content
This repository has been archived by the owner on Feb 15, 2021. It is now read-only.

Replace serialization references with the schema-like $ref and a pointer. #152

Closed
gregsdennis opened this issue Mar 22, 2018 · 1 comment
Closed

Replace serialization references with the schema-like $ref and a pointer. #152

gregsdennis opened this issue Mar 22, 2018 · 1 comment
Assignees
@gregsdennis
Labels
breaking-change The changes proposed/implemented here will break your code. feature Something new.
Milestone
v10.0.0

Comments

@gregsdennis
Copy link
Owner

This may or may not be a breaking change. I'm not entirely sure. Be safe.

Currently, I use custom #def and #ref tag (or something similar) with a guid to link them. This would remove the #def tag and replace #ref with $ref with a pointer to the correct value.
@gregsdennis gregsdennis added feature Something new. breaking-change The changes proposed/implemented here will break your code. labels Mar 22, 2018
@gregsdennis gregsdennis self-assigned this Mar 22, 2018
@gregsdennis gregsdennis added this to the v10.0.0 milestone Mar 23, 2018
@gregsdennis
Copy link
Owner Author

Something else is borked with this. It's placing the #Ref tags, but not the #Def tags. Deserialization will always fail. Not sure how my tests are passing...

@gregsdennis gregsdennis mentioned this issue Sep 24, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gregsdennis gregsdennis

Labels
breaking-change The changes proposed/implemented here will break your code. feature Something new.
Projects
None yet
Milestone
v10.0.0
Development

No branches or pull requests
1 participant
@gregsdennis