Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic/functional #708

Merged
merged 10 commits into from
Apr 18, 2024
Merged

Logic/functional #708

merged 10 commits into from
Apr 18, 2024

Conversation

gregsdennis
Copy link
Collaborator

Added a new "functional," model-less implementation.

Benchmark shows considerable improvement over the existing implementation.

| Method | Count | Mean         | Error       | StdDev      | Gen0       | Allocated   |
|------- |------ |-------------:|------------:|------------:|-----------:|------------:|
| Models | 1     |   1,655.9 us |    26.76 us |    26.28 us |   410.1563 |   838.03 KB |
| Nodes  | 1     |     734.5 us |     8.16 us |     7.23 us |   236.3281 |   482.61 KB |
| Models | 10    |  16,269.0 us |   167.06 us |   139.50 us |  4093.7500 |   8380.5 KB |
| Nodes  | 10    |   7,210.7 us |    25.26 us |    21.09 us |  2359.3750 |  4826.08 KB |
| Models | 100   | 164,267.3 us | 2,227.54 us | 1,974.66 us | 41000.0000 | 83803.81 KB |
| Nodes  | 100   |  72,195.7 us |   139.28 us |   116.30 us | 23571.4286 | 48262.05 KB |

Models is the current implementation; Nodes is the new one.

Will be updating the docs for using this approach, and I think this deserves a blog post.

Relates (tangentially) to #552.

Copy link

github-actions bot commented Apr 18, 2024

Test Results

    15 files      15 suites   12s ⏱️
21 041 tests 19 681 ✅ 1 360 💤 0 ❌
21 133 runs  19 770 ✅ 1 363 💤 0 ❌

Results for commit 282a9e1.

♻️ This comment has been updated with latest results.

@gregsdennis gregsdennis merged commit f9e9cab into master Apr 18, 2024
6 checks passed
@gregsdennis gregsdennis deleted the logic/functional branch April 18, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant