Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subpackage eslint-plugin-jsdoc version not compatible with node 18+ #32

Closed
scheinercc opened this issue Dec 7, 2022 · 9 comments
Closed
Labels
Type: Upstream Issues with upstream dependencies

Comments

@scheinercc
Copy link

Hey Greg, that is more of an FYI ticket

WordPress/gutenberg#46386

@gregsullivan gregsullivan added the Type: Upstream Issues with upstream dependencies label Dec 8, 2022
@gregsullivan
Copy link
Owner

Thanks for this! If I have time next week, I'll try to take a deeper look to see what needs to be done to push this forward. I think the blocker right now is the extent of the code changes required to make the update absent configuration changes.

@gregsullivan
Copy link
Owner

@scheinercc I've spent some more time looking into this, and I'm beginning to wonder if this will end up being a choice between supporting either @wordpress/eslint-plugin or the latest LTS version of Node, at least for the medium term. (I no longer think there's a configuration option that will prevent changes throughout Gutenberg as a consequence of this version change, but I'd love to be proven wrong.)

I suspect I'd come down on the side of supporting more recent versions of Node, and basically following this proposal:

https://make.wordpress.org/core/2022/01/05/proposal-changes-to-javascript-coding-standards-for-full-prettier-compatibility/

What do you think?

@scheinercc
Copy link
Author

I suspect I'd come down on the side of supporting more recent versions of Node, and basically following this proposal:

Sounds good to me. I support Greg's reasoning as well and am more used to the default Prettier styling for JS anyway. Thanks for looking into it!

@gregsullivan
Copy link
Owner

Okay, great! I was thinking of simply swapping plugin:@wordpress/eslint-plugin/esnext for eslint:recommended as the value for extends and letting people add plugins as their project demands.

Do you see any issues with that approach?

@scheinercc
Copy link
Author

Do you see any issues with that approach?

Nope.

@gregsullivan
Copy link
Owner

I'm hoping to move forward with this later this week!

@gregsullivan
Copy link
Owner

I finally got around to making this change:

64b724e

I'm going to close this issue, but if you have any feedback, please let me know!

@scheinercc
Copy link
Author

Awesome. Thanks Greg!

@gregsullivan
Copy link
Owner

You're very welcome—thanks again for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Upstream Issues with upstream dependencies
Projects
None yet
Development

No branches or pull requests

2 participants