New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subpackage eslint-plugin-jsdoc version not compatible with node 18+ #32
Comments
Thanks for this! If I have time next week, I'll try to take a deeper look to see what needs to be done to push this forward. I think the blocker right now is the extent of the code changes required to make the update absent configuration changes. |
@scheinercc I've spent some more time looking into this, and I'm beginning to wonder if this will end up being a choice between supporting either I suspect I'd come down on the side of supporting more recent versions of Node, and basically following this proposal: What do you think? |
Sounds good to me. I support Greg's reasoning as well and am more used to the default Prettier styling for JS anyway. Thanks for looking into it! |
Okay, great! I was thinking of simply swapping Do you see any issues with that approach? |
Nope. |
I'm hoping to move forward with this later this week! |
I finally got around to making this change: I'm going to close this issue, but if you have any feedback, please let me know! |
Awesome. Thanks Greg! |
You're very welcome—thanks again for reporting the issue! |
Hey Greg, that is more of an FYI ticket
WordPress/gutenberg#46386
The text was updated successfully, but these errors were encountered: