Warning "'next' may be used uninitialized in this function"

[FrankBoesing]

SdFat-beta/src/ExFatLib/ExFatPartition.cpp

Line 225 in 790dd84

if ((cluster + 1) != next || status == 0) {

GCC 10 prints the mentioned warning.

[greiman]

next should be set at line 225 by this if status is one.

    status = fatGet(cluster, &next);
    if (status < 0) {
      DBG_FAIL_MACRO;
      goto fail;
    }

I will double check fatGet since is may have a problem.

[greiman]

It appears the program works OK but I made two changes that may suppress the warning.

First the return type of fatGet is wrong. it should be int8_t but all calls use int8_t for tests.

next is not used unless the return status is one. I changed this test to not use next unless status is one.

if (status == 0 || (cluster + 1) != next) {

I should probably change the loop to not execute these assigns before returning.

      start = next;
    }
    cluster = next;
  } while (status);

I did change fatGet to set next to EOC for return 0 so the compiler should not give the warning. If EOC is used, a crash or error will occur.

[FrankBoesing]

Thank you, Bill !