Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WinstonOptionFactory #75

Closed
TrejGun opened this issue Dec 2, 2019 · 5 comments
Closed

WinstonOptionFactory #75

TrejGun opened this issue Dec 2, 2019 · 5 comments

Comments

@TrejGun
Copy link
Contributor

TrejGun commented Dec 2, 2019

please add WinstonOptionFactory so users can create WinstonConfigService to pass in useClass property for forRootAsync
@Piranit
Copy link
Contributor

Piranit commented Dec 3, 2019

Hi
It's already implemented in my pull request.
We are expecting a new version with this changes.

@gremo
Copy link
Owner

gremo commented Dec 3, 2019

@Piranit is right. Sorry for the late release. I'll try to do in today. I was a little busy and I tried to refactor and lint the code before releasing.

@TrejGun
Copy link
Contributor Author

TrejGun commented Dec 3, 2019

thanks guys

@gremo
Copy link
Owner

gremo commented Dec 3, 2019

New released version 1.3 should contain the pull request.

@gremo gremo closed this as completed Dec 3, 2019
@TrejGun
Copy link
Contributor Author

TrejGun commented Dec 3, 2019

@gremo can you please export it from the root?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TrejGun @gremo @Piranit