Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AndroidManifest.xml application label #7

Closed
franciscoaleixo opened this issue Feb 6, 2017 · 2 comments
Closed

AndroidManifest.xml application label #7

franciscoaleixo opened this issue Feb 6, 2017 · 2 comments
Labels
enhancement

Comments

@franciscoaleixo
Copy link

Hi, is there any specific reason as to why android:label is used in the library? I'm asking since it causes conflicts when merging the AndroidManifests.

Now, I know there's workarounds (like using tools:replace) but if it's not needed, could you remove it? It just adds unnecessary clutter.

Thanks in advance 👍
@GrenderG
Copy link
Owner

GrenderG commented Feb 6, 2017

You are right, I will check it.

@GrenderG
Copy link
Owner

GrenderG commented Feb 7, 2017

Solved in v. 1.1.3.

@GrenderG GrenderG closed this as completed Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franciscoaleixo @GrenderG