Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.1.3 breaks API compatibility from 2.1.2 #157

Closed
StFS opened this issue Jan 23, 2019 · 1 comment
Closed

Version 2.1.3 breaks API compatibility from 2.1.2 #157

StFS opened this issue Jan 23, 2019 · 1 comment

Comments

@StFS
Copy link

StFS commented Jan 23, 2019

The following change adds an abstract method to the net.greghaines.jesque.client.Client class: 52fb913

This breaks compilation in our project since we've subclassed the ResqueClient class.

I would argue that the version published after this change should at least be a minor version (2.1.2 -> 2.2.0), but not a patch version as was the case (2.1.2 -> 2.1.3).

@gresrun
Copy link
Owner

gresrun commented Feb 4, 2019

OK. Too late now. 🤷‍♂️

@gresrun gresrun closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants