Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make greta depend on R 3.1 #386

Closed
njtierney opened this issue Apr 22, 2021 · 3 comments
Closed

make greta depend on R 3.1 #386

njtierney opened this issue Apr 22, 2021 · 3 comments
Assignees
Labels
Milestone

Comments

@njtierney
Copy link
Collaborator

This avoids this issue that came into place in 4.0.3

The LINPACK argument to chol.default(), chol2inv(), solve.default() and svd() has been defunct since R 3.1.0. Using it now gives a warning which will become an error in R 4.1.0.
@njtierney
Copy link
Collaborator Author

Also need to not pass through the LINPACK argument to chol.default and co

@njtierney njtierney self-assigned this Apr 27, 2021
@njtierney
Copy link
Collaborator Author

test in test_functions.R returns:

══ Testing test_functions.R ════════════════════════════════════════════════════
[ FAIL 0 | WARN 1 | SKIP 0 | PASS 454 ]

── Warning (test_functions.R:113:3): matrix functions work as expected ─────────
the LINPACK argument has been defunct since R 3.1.0
Backtrace:
 1. check_op(chol2inv, c) test_functions.R:113:2
 2. run_r_op(op, a, b, other_args) helpers.R:187:2
 5. greta::chol2inv.default(...) /Users/njtierney/github/njtierney/greta-dev/greta/R/functions.R:411:2
 6. base::chol2inv(x = x, size = size, LINPACK = LINPACK) /Users/njtierney/github/njtierney/greta-dev/greta/R/functions.R:416:2

[ FAIL 0 | WARN 1 | SKIP 0 | PASS 454 ]

@njtierney
Copy link
Collaborator Author

Now provides:

==> Testing R file using 'testthat'

ℹ Loading greta

══ Testing test_functions.R ════════════════════════════════════════════════════
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 453 ] Done!

Test complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant