Add glob matching #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add --include option. - Add pattern matching in filter_allows. - Add patterns in Config. - Defaults patterns accepts "Cargo.toml", "Cargo.lock", "src/**/*.rs", "tests/**/*.rs" and "build.rs". - Ignore hidden files (starting with a dot) by default.
Strip project dir prefix from modified files instead of concatenating project dir and glob patterns.
Remove usage of the nightly feature (issue number unknown) which caused this error:
```
154 | fn filter_allows(project_dir: &Path, patterns: &[Pattern], mut path: &Path) -> bool {
| ----- -----
| |
| these two types are declared with different lifetimes...
...
162 | path = p;
| ^ ...but data from `project_dir` flows into `path` here% ```
greyblake
reviewed
May 11, 2018
src/config.rs
Outdated
| } | ||
|
|
||
| impl<'a> ConfigBuilder<'a> { | ||
| pub fn new() -> Self { | ||
| let defaults_pattenrs = vec
There was a problem hiding this comment.
There is a little typo in pattenrs
greyblake
reviewed
May 11, 2018
src/lib.rs
Outdated
| .short("i") | ||
| .long("include") | ||
| .takes_value(true) | ||
| .help("Comma separated list of include pattern")) |
There was a problem hiding this comment.
I would add in addition to the predefined default patterns
|
@Hugal31 Thank you for your PR. I am ready to merge this after addressing few very minor notes. |
|
Done! Thank you for the review! |
|
@Hugal31 Thank you! Sorry for the delay. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #7
Cargo.tomlCargo.locksrc/**/*.rstests/**/*.rsbuild.rs--includeoption to add custom patterns.