New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the async-related tests #324
Conversation
The fixture with |
I think this looks good now 👍🏻 |
@greyli |
@9gl looks like it might be because you removed the blank line at the end of the file. Not sure. |
@9gl It's Ok, I will take care of this later. For development, you can refer to the contributing guide. The
It indicated that line 107 in |
Merged, thanks! I squashed the commits, so you will need to reset your main branch:
Next time please use different branches to submit PRs (check out the contributing guide). |
Implemented a fixture for the "skip async test" function since all test in that file will requires Flask > 2.0
suggested by jonasps and greyli
apiflask/tests/test_async.py
Before
After
To improve it
Checklist:
docs
folder and in code docstring.CHANGES.md
summarizing the change and linking to the issue and your username.*Version changed*
or*Version added*
note in any relevant docs and docstring.pytest
andtox
, no tests failed.