Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show links in table text #204

Merged
merged 5 commits into from
May 22, 2022
Merged

show links in table text #204

merged 5 commits into from
May 22, 2022

Conversation

PanderMusubi
Copy link
Collaborator

@PanderMusubi PanderMusubi commented Jan 30, 2022

Please review, fixes most important part of #118 which can be closed IMHO.

fixes #118

@PanderMusubi
Copy link
Collaborator Author

@greyli I saw that table does not have tests yet for Bootstrap 5. Shall I make an issue for that?

@PanderMusubi
Copy link
Collaborator Author

@greyli can you review and hopefully merge this PR please? Thanks.

@greyli
Copy link
Member

greyli commented May 9, 2022

Thanks, I will review it this weekend. Please add docs for the newly added parameters.

docs/macros.rst Outdated Show resolved Hide resolved
docs/macros.rst Outdated Show resolved Hide resolved
flask_bootstrap/templates/base/table.html Outdated Show resolved Hide resolved
flask_bootstrap/templates/base/table.html Outdated Show resolved Hide resolved
Copy link
Member

@greyli greyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Could you add some unit tests and update the changelog?

docs/macros.rst Outdated Show resolved Hide resolved
docs/macros.rst Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2022

Codecov Report

Merging #204 (dcc6c0a) into master (7de1ad4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files           1        1           
  Lines         134      134           
  Branches       23       23           
=======================================
  Hits          130      130           
  Misses          1        1           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de1ad4...dcc6c0a. Read the comment docs.

@PanderMusubi PanderMusubi requested a review from greyli May 22, 2022 09:21
@greyli greyli merged commit 525eb77 into helloflask:master May 22, 2022
@greyli
Copy link
Member

greyli commented May 22, 2022

Merged, thanks!

@PanderMusubi PanderMusubi deleted the table-links branch July 24, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rendering hybrid_properties in tables
3 participants