Implemented get_table_by_scope #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnordberg
requested changes
Apr 22, 2021
src/api/v1/types.ts
Outdated
| @@ -370,3 +370,28 @@ export interface GetTableRowsResponse<Index = TableIndexType, Row = any> { | |||
| ram_payers?: Name[] | |||
| next_key?: Index | |||
| } | |||
|
|
|||
| export interface GetTableByScopeParams<Index = TableIndexType | string> { | |||
There was a problem hiding this comment.
There is no index type or payer:
struct get_table_by_scope_params {
name code; // mandatory
name table; // optional, act as filter
string lower_bound; // lower bound of scope, optional
string upper_bound; // upper bound of scope, optional
uint32_t limit = 10;
optional<bool> reverse;
};
There was a problem hiding this comment.
lol, then I shouldn't be following the official documentation:
src/api/v1/types.ts
Outdated
| @Struct.type('get_table_by_scope_response') | ||
| export class GetTableByScopeResponse extends Struct { | ||
| @Struct.field(GetTableByScopeResponseRow, {array: true}) rows!: GetTableByScopeResponseRow[] | ||
| @Struct.field('name') more!: Name |
There was a problem hiding this comment.
more is a string
struct get_table_by_scope_result {
vector<get_table_by_scope_result_row> rows;
string more; ///< fill lower_bound with this value to fetch more rows
};
There was a problem hiding this comment.
It is returning a name value, as in an account. Shouldn't we type that as a name?
|
Any reason not to merge this? |
|
I had the changes Johan requested, but they weren't pushed up until now. |
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.