Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Added tests for ints with values over 53bits #50

Closed

Conversation

ericpassmore
Copy link
Contributor

By default JS number handle values up to 53bits. Added two serialization and deserialization tests showing eosio-core supports UInt64 and Int64.

Resolved #48

@jnordberg
Copy link
Collaborator

Thanks! Although integers are already tested extensively in ./test/integer.ts, perhaps you missed that? These tests does not change test coverage over the integer types.

I'm not opposed to adding these tests anyways if you feel they add value. The reliance on BigInt has to go though as well as the direct import of '../src' in the test files since both those things will break the browser tests

@ericpassmore
Copy link
Contributor Author

LOL, its a pull request with little value. I'll go ahead an close it.

I did the test for my own learning, and double-check. I didn't find any serialization/deserialization tests for Int64, and I decided to create the PR. Thanks for taking a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[eosio-core] Test Serialization Deserialization of Int64 and UInt64 with values over 53bits
2 participants