Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ready and Load events are not being triggered #1295

Closed
neto737 opened this issue Jan 25, 2023 · 6 comments
Closed

[BUG] Ready and Load events are not being triggered #1295

neto737 opened this issue Jan 25, 2023 · 6 comments
Labels
wontfix This will not be worked on

Comments

@neto737
Copy link

neto737 commented Jan 25, 2023

Describe the bug
"Load" and "Ready" events are not working after update to v6.x

To Reproduce
Steps to reproduce the behavior:

  1. Create a table with server-side data, pagination, sorting and search (I didn't test removing any of these plugins)
  2. Render a table
  3. Put a console log or whatever in a Grid.js event listener function
  4. Nothing will happen, no logs on browser console

Expected behavior
Execute the code after the event trigger

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Google Chrome
  • Version: 109.0.5414.120
  • Probably non-browser specific and non device specific
@neto737 neto737 changed the title [BUG] [BUG] Ready and Load events are not being triggered Jan 25, 2023
@KillerDom1123
Copy link

Any idea how to work around this at all? This makes it all the more annoying to work around #1248 ☹️

@neto737
Copy link
Author

neto737 commented Mar 16, 2023

Any idea how to work around this at all? This makes it all the more annoying to work around #1248 ☹️

I actually downgraded my GridJS to latest v5.x version, hope to update to latest version when this issue gets fixed

@KillerDom1123
Copy link

That's a shame. Any idea what the major changes from the current latest version to 5.x is please @neto737?

@rhyanmacedosilva
Copy link

Confirmed, I just reproduced the bug here, and also reverted to the latest release of version 5.

@j-greig
Copy link

j-greig commented Apr 18, 2023

From a quick check, the beforeLoad, load, and ready event emitters are not even in the compiled code for v6.

If anyone else needs a temporary fix you can use the last v5 update directly from the CDN at https://cdn.jsdelivr.net/npm/gridjs@5.1.0/dist/gridjs.production.min.js

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 18, 2023
@stale stale bot closed this as completed Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants