Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

March 4 | Add native html iframe support (Youtube, Google maps, Webcam), html progress support #132

Merged
merged 13 commits into from
Mar 29, 2022

Conversation

softmarshmallow
Copy link
Member

@softmarshmallow softmarshmallow commented Mar 28, 2022

1. iframe support - Youtube, Google maps, Webcam

Grida March #4 - Extended Embed Views (Youtube, Google maps, Camera)-high

watch the demo on vimeo

2. Progressbar with native html <progress> tag (indeterminate with accent color)

Screen.Recording.2022-03-28.at.11.55.17.AM.mov

we use different strategy for indeterminate (empty value) and standard.

for indeterminate, to preserve the native loading animation, we do not clear the css appearance property, only provide the accent-color property.

References

@vercel
Copy link

vercel bot commented Mar 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/grida/designto-codes/4bbnECMW6i3wtN7tuUoDmavQN7aL
✅ Preview: https://staging-branch-code.grida.co

@softmarshmallow softmarshmallow changed the title Add native html progress support (indeterminate with accent color) Add native html progress support, html iframe support (Youtube, Google maps, Webcam) Mar 29, 2022
@softmarshmallow softmarshmallow changed the title Add native html progress support, html iframe support (Youtube, Google maps, Webcam) Add native html iframe support (Youtube, Google maps, Webcam), html progress support Mar 29, 2022
@softmarshmallow softmarshmallow merged commit b381d8e into main Mar 29, 2022
@softmarshmallow softmarshmallow changed the title Add native html iframe support (Youtube, Google maps, Webcam), html progress support March 4 | Add native html iframe support (Youtube, Google maps, Webcam), html progress support Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant