Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing permanent memory storage in BoundaryDiscreteModel and DiscreteModelPortion ? #641

Closed
amartinhuertas opened this issue Aug 16, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request performance Performance enhancements

Comments

@amartinhuertas
Copy link
Member

Hi @fverdugo, @santiagobadia

while taking a careful look at the current implementation of BoundaryDiscreteModel and DiscreteModelPortion, I am wondering whether it is possible (or not) to reduce the amount of permanent memory storage that these data types require.

In particular, the former stores a reference to the background model here:

bgmodel::DiscreteModel

and the latter here:

parent_model::DiscreteModel{Dc,Dp}

The former member variable seems not to be used, while the latter, only in the get_parent_model getter, which I am not sure if it is actually used or not.

The motivation behind not requiring these references is that the memory occupied by the models from which these are created can be removed early via GC.

Let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Performance enhancements
Projects
None yet
Development

No branches or pull requests

3 participants