Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name conflict with Statistics #814

Closed
lhupe opened this issue Jul 15, 2022 · 3 comments · Fixed by #988
Closed

Name conflict with Statistics #814

lhupe opened this issue Jul 15, 2022 · 3 comments · Fixed by #988
Assignees
@JordiManyer
Milestone
v0.18

Comments

@lhupe
Copy link

lhupe commented Jul 15, 2022

Gridap defines and exports a mean function (in /src/CellData/CellFields.jl) that conflicts with the Statistics standard library.
Is there a specific reason to define a new function instead of extending Statistics.mean in Gridap?
@fverdugo
Copy link
Member

The is no specific reason. We can fix this for the next (breaking) release

@fverdugo fverdugo added this to the v0.18 milestone Jul 15, 2022
@kishore-nori
Copy link
Collaborator

Great, this would fix the problem of name clash when using BenchmarkTools.jl

@JordiManyer JordiManyer self-assigned this Mar 27, 2024
@JordiManyer JordiManyer mentioned this issue Mar 27, 2024
Merged
@JordiManyer JordiManyer linked a pull request Mar 27, 2024 that will close this issue
Fixing name clash with Statistics.mean #988
Merged
@JordiManyer
Copy link
Member

Will be part of v0.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JordiManyer JordiManyer

Labels
None yet
Projects
None yet
Milestone
v0.18
Development

Successfully merging a pull request may close this issue.

Fixing name clash with Statistics.mean gridap/Gridap.jl
4 participants
@lhupe @JordiManyer @fverdugo @kishore-nori