Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_normal_vector with AdaptedTriangulation (atop BoundaryTriangulation) fails #883

Closed
amartinhuertas opened this issue Mar 8, 2023 · 0 comments · Fixed by #884
Closed
Assignees
Labels
bug Something isn't working

Comments

@amartinhuertas
Copy link
Member

Error with Gridap 0.17.17

MWE

using Gridap
modelH = CartesianDiscreteModel((0,1,0,1),(2,2))
ΓH = BoundaryTriangulation(modelH)
get_normal_vector(ΓH) # ! OK!

modelh = Gridap.Adaptivity.refine(modelH)
Γh = BoundaryTriangulation(modelh)
get_normal_vector(Γh) # ! Crashes

Error report:


ERROR: AssertionError: This Grid does not have information about normals.
Stacktrace:
 [1] get_facet_normal(g::Gridap.Geometry.UnstructuredGrid{1, 2, Float64, Gridap.Geometry.NonOriented, Nothing})
   @ Gridap.Geometry ~/git-repos/Gridap.jl/src/Geometry/UnstructuredGrids.jl:114
 [2] get_facet_normal(grid::Gridap.Geometry.GridView{1, 2, Gridap.Geometry.UnstructuredGrid{1, 2, Float64, Gridap.Geometry.NonOriented, Nothing}, Vector{Int64}})
   @ Gridap.Geometry ~/git-repos/Gridap.jl/src/Geometry/GridPortions.jl:188
 [3] get_facet_normal(trian::Gridap.Adaptivity.AdaptedTriangulation{1, 2, BoundaryTriangulation{1, 2, Gridap.Geometry.BodyFittedTriangulation{1, 2, CartesianDiscreteModel{2, Float64, typeof(identity)}, Gridap.Geometry.GridView{1, 2, Gridap.Geometry.UnstructuredGrid{1, 2, Float64, Gridap.Geometry.NonOriented, Nothing}, Vector{Int64}}, Vector{Int64}}, Gridap.Geometry.FaceToCellGlue{Vector{Int64}, FillArrays.Fill{Int64, 1, Tuple{Base.OneTo{Int64}}}, Gridap.Arrays.LazyArray{FillArrays.Fill{Reindex{Vector{Int8}}, 1, Tuple{Base.OneTo{Int64}}}, Int8, 1, Tuple{Vector{Int64}}}, FillArrays.Fill{Int8, 1, Tuple{Base.OneTo{Int64}}}}}, Gridap.Adaptivity.AdaptedDiscreteModel{2, 2, CartesianDiscreteModel{2, Float64, typeof(identity)}, CartesianDiscreteModel{2, Float64, typeof(identity)}, Gridap.Adaptivity.AdaptivityGlue{Gridap.Adaptivity.RefinementGlue, 2, Vector{Vector{Int64}}, Vector{Int64}, FillArrays.Fill{Gridap.Adaptivity.RefinementRule{Gridap.ReferenceFEs.ExtrusionPolytope{2}, Gridap.Geometry.UnstructuredDiscreteModel{2, 2, Float64, Gridap.Geometry.Oriented}}, 1, Tuple{Base.OneTo{Int64}}}, Gridap.Arrays.Table{Int64, Vector{Int64}, Vector{Int64}}, FillArrays.Fill{Bool, 1, Tuple{Base.OneTo{Int64}}}}}})
   @ Gridap.Geometry ~/git-repos/Gridap.jl/src/Geometry/Triangulations.jl:43
 [4] get_normal_vector(trian::Gridap.Adaptivity.AdaptedTriangulation{1, 2, BoundaryTriangulation{1, 2, Gridap.Geometry.BodyFittedTriangulation{1, 2, CartesianDiscreteModel{2, Float64, typeof(identity)}, Gridap.Geometry.GridView{1, 2, Gridap.Geometry.UnstructuredGrid{1, 2, Float64, Gridap.Geometry.NonOriented, Nothing}, Vector{Int64}}, Vector{Int64}}, Gridap.Geometry.FaceToCellGlue{Vector{Int64}, FillArrays.Fill{Int64, 1, Tuple{Base.OneTo{Int64}}}, Gridap.Arrays.LazyArray{FillArrays.Fill{Reindex{Vector{Int8}}, 1, Tuple{Base.OneTo{Int64}}}, Int8, 1, Tuple{Vector{Int64}}}, FillArrays.Fill{Int8, 1, Tuple{Base.OneTo{Int64}}}}}, Gridap.Adaptivity.AdaptedDiscreteModel{2, 2, CartesianDiscreteModel{2, Float64, typeof(identity)}, CartesianDiscreteModel{2, Float64, typeof(identity)}, Gridap.Adaptivity.AdaptivityGlue{Gridap.Adaptivity.RefinementGlue, 2, Vector{Vector{Int64}}, Vector{Int64}, FillArrays.Fill{Gridap.Adaptivity.RefinementRule{Gridap.ReferenceFEs.ExtrusionPolytope{2}, Gridap.Geometry.UnstructuredDiscreteModel{2, 2, Float64, Gridap.Geometry.Oriented}}, 1, Tuple{Base.OneTo{Int64}}}, Gridap.Arrays.Table{Int64, Vector{Int64}, Vector{Int64}}, FillArrays.Fill{Bool, 1, Tuple{Base.OneTo{Int64}}}}}})
   @ Gridap.CellData ~/git-repos/Gridap.jl/src/CellData/CellFields.jl:108
 [5] top-level scope
   @ Untitled-2:8

Should be easy to fix. Just to implement the corresponding high-level API function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants