Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Face labelling tags of an UnstructuredDiscreteModel changed after refining #890

Closed
wei3li opened this issue Mar 23, 2023 · 5 comments · Fixed by #886
Closed

Face labelling tags of an UnstructuredDiscreteModel changed after refining #890

wei3li opened this issue Mar 23, 2023 · 5 comments · Fixed by #886
Assignees
Labels
bug Something isn't working

Comments

@wei3li
Copy link
Collaborator

wei3li commented Mar 23, 2023

Hi @amartinhuertas and @JordiManyer,

I build an UnstructuredDiscreteModel by loading a Gmsh file, then I refine the model. The issue is that the face labelling tags of the refined model are not the same as the original model. Could you please look into this?
The following is an MWE.

using Gridap, GridapGmsh

model = GmshDiscreteModel("square.txt")
println(get_face_labeling(model).tag_to_name)
# prints ["dirichlet_points", "dirichlet_surfaces", "neumann_surface"]
refined_model = Gridap.Adaptivity.refine(model)
println(get_face_labeling(refined_model).tag_to_name)
# prints ["interior", "boundary"]

Gridap version: master branch
GridapGmsh version: v0.6.0
Mesh file: square.txt

@JordiManyer
Copy link
Member

I see... this is a hard thing to do in general, but i think child-face-related developments in #886 can be just the thing we need. What kind of polytope + refinement do you need this for?

@JordiManyer JordiManyer added the bug Something isn't working label Mar 23, 2023
@JordiManyer JordiManyer linked a pull request Mar 23, 2023 that will close this issue
6 tasks
@amartinhuertas
Copy link
Member

Triangles 1:4 refinement

@JordiManyer
Copy link
Member

@wei3li , @amartinhuertas I think I've successfully fixed the issue. Could you try to run your code using the refinement-rule-subface-glue branch? Let me know if it fixes the issue.

@wei3li
Copy link
Collaborator Author

wei3li commented Mar 26, 2023

Hi @JordiManyer, I've tested with branch refinement-rule-subface-glue, and the labels are correct now. Thanks so much for fixing this issue!

@JordiManyer
Copy link
Member

No worries! I'll close the issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants