Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gui] Transaction History becomes cluttered after rainbymagnitude #2165

Closed
NetherStar64 opened this issue Jun 6, 2021 · 7 comments
Closed

Comments

@NetherStar64
Copy link

After doing a rainbymagnitude, the transaction list in the gui is cluttered with many small transactions. It would look better if e.g. it was in a single entry
image

@jamescowens
Copy link
Member

This cannot be supported right now, because a rain transaction is currently essentially a regular transaction that has a lot of outputs. There is no separate contract for rain, and so there is no programmatic way to distinguish between a regular transaction and a rain. If we decide to create a contract for rain, which is likely, I will revisit this, but I am skeptical, because the request violates the rules that the transaction lists each payee in a send transaction separately so you have a visible record of where the funds went to.

@jamescowens
Copy link
Member

I have decided to leave this open as a feature request for discussion.

@RoboticMind
Copy link
Contributor

... the request violates the rules that the transaction lists each payee in a send transaction separately so you have a visible record of where the funds went to.

Perhaps it could instead have a expand/contract button on the transaction instead? Although that might cause big performance issues with hundreds of transactions

@jamescowens
Copy link
Member

jamescowens commented Jun 7, 2021

That is probably not workable... and it is not worth the effort for this corner-case.

@NetherStar64
Copy link
Author

NetherStar64 commented Jun 7, 2021 via email

@jamescowens
Copy link
Member

It already is in the details. The issue is being able to special case this situation to NOT display the details for a rain in the transaction grid. This cannot be done without rain being implemented with a rain contract to be able to distinguish between a rain and an ordinary transaction.

@jamescowens
Copy link
Member

There is a complicated decomposition function that maps between core transactions and the displayed transactions in the GUI. In general, the core transactions are much more coarse-grained. One core transaction maps to one or more displayed transaction rows depending on nature of the transaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants