Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade downloads are unnecessarily bloated with base64 encoding #99

Closed
Bouowmx opened this issue Jul 24, 2016 · 1 comment
Closed

Upgrade downloads are unnecessarily bloated with base64 encoding #99

Bouowmx opened this issue Jul 24, 2016 · 1 comment

Comments

@Bouowmx
Copy link

Bouowmx commented Jul 24, 2016

Encoding binary in base64 in base64 being 133% (8/6) size of binary. If relavent, this occurs in Windows.

grcrestarter2.log in Program Files, renamed to txt to allow upload to GitHub: grcrestarter2.txt

Preview:

2016-07-24 10:37:33, Downloading blob with length 9593 starting with <BLOB>4E/CocPjdcpV8mKdJ3ioKGFN8SZqxlIieQdNturp4sUA9bZOdZcxz7mJleQnqlWE6nMSpGQaHFdbT2LUJobikKu8j0QnyCGbUmVOqgQ9WKnz2deKiUqPRHYGdtKcoIemZF4yFX8yoF60IaFZUCaXHOA8Mw2L4JCvEXLC1ul0Q6zXEnGNbvWHHJZAGuG4/aRgLNlLjAkxYXO7RC/SEw7kbmluRWeDE2sII7w9WotoW1HdNlN6XQxiHB5Nsv+/pAwBJSb1X0PUtpt435wcZd1KANaX5/hzAzrBUhBKYpFhYpr6Ss7Deme0D0XT0y3PuyiXSU3B69krXmwxf3rYsojgC8vA/H5dsIR++yVjui2BezW5IsR2YC8L0aEC0bKhelCs+W9Q7k03x57i1WJO8Yb/uOZGR+zMHqWTg8g0ta3KWmo3M7bp0fLBzEP2ZvOx3IkNYwxXDL1zpmUTmoMCLZ0uCcioX1EHGUKr+OlfmzYXx3Pg5onN1TsCeQzzoh1xxzu/Fx9C+JyhVmCcKMxPQ961KyKAYaMGFyFQzyadWKKopA1cUrVrMQsCAcoSPn67caMXk1WdF+mBpjleFrQB/DALhvkeqOaE9mJoAAlM/3pacC9khuSB4Q6MwHs6XywcnZtQNeiFVKb+EVtQTqBj9tAahZetdBvjLa5dGwfLjZWiSwrTzgqkuy2SdDNhB8Vz23yUF9o9dnLYaLzS4MvG9i/3UB7GInGfYd/isRhOTQw0Hwz5aiF9Qyjs468jf9gtSVuZGE+tOiSmtEw1EZXV4q+/x/rq0pVGQTlzadGRGhk0lJ3p8bOgPCBJBy2BPPLiXrauXVbKz4QzeWndIOsf/bLNZQv6N5y+Srv0tOelT//6tKjELK6SGMB8d2R7W5qbKOFD+THpe86cDH1baP1hilsOLtE9LiPoPNjObRiWDX6Z1322L2TlsamWqA37igtRl/G6tTy+9acnxBgbSSLVF87qOePKVZxv38ie+4
2016-07-24 10:37:33, Converting base64 encoded byte array length 9580 starting with 4E/CocPjdcpV8mKdJ3ioKGFN8SZqxlIieQdNturp4sUA9bZOdZcxz7mJleQnqlWE6nMSpGQaHFdbT2LUJobikKu8j0QnyCGbUmVO
2016-07-24 10:37:33, Decrypted byte array length 7168
2016-07-24 10:37:33, Writing bytes to C:\Program Files (x86)\GridcoinResearch\\gpuenumerator.dll with length 7168
2016-07-24 10:37:33, Closing file.

Binary downloads should be done as is, no base64 conversion.

@gridcoin
Copy link
Contributor

Looks like this .NET code converts binary to base64 and back for several reasons, none of which have to do with storage space.

The only files downloaded are Changed files, so the process is fairly efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants