Optimize cdbl #692
Merged
Optimize cdbl #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
atof does not throw :) |
iFoggz
approved these changes
Oct 14, 2017
denravonska
force-pushed
the
optimize-cdbl
branch
from
92bf867
to
31d5d83
Compare
I checked 22 million cdbl calls while syncing and none of them required cleaning. The new implementation uses 18% of the execution time compared to the old one. This is negligleble on modern hardware, but an old Raspbeery Pi should see a greater boost.
denravonska
force-pushed
the
optimize-cdbl
branch
from
31d5d83
to
6453e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace cdbl implementation with atof+round and move it to util as
RoundFromString.I checked 22 million cdbl calls while syncing and none of them required cleaning. The new implementation uses 18% of the execution time compared to the old one. This is negligleble on modern hardware, but an old Raspbeery Pi should see a greater boost.