Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for next mandatory #700

Merged
merged 8 commits into from
Oct 25, 2017

Conversation

tomasbrod
Copy link
Member

@tomasbrod tomasbrod commented Oct 21, 2017

Status: testing.
Attempt 2 of #689. Improvements for smoother mandatory upgrade.
Add V9 block foundation.
Tie forking changes to block version 9: #524 (Beaconchecks) and #577 (ClearCache).
Improve storage of contract TrxID for debug purposes.
Fix newbie stake reward #552, @Foggyx420 PR was outdated.
Finally prevent duplicate superblocks for @Erkan-Yilmaz.

Note: a tally fix, which was included in #689, is not included in this PR. IMO it should be released in next update too.

Hope it works.

@tomasbrod tomasbrod force-pushed the forkmandatory branch 2 times, most recently from e43a66b to fa04f9e Compare October 21, 2017 13:43
Also enables the check for all incoming loose transactions even before
mandatory, but skips the check for transaction included in pre-mandatory
blocks. This way it is more reliable in case of reorgs.
@tomasbrod
Copy link
Member Author

Updated to reflect recent changes.

@@ -8255,7 +8278,8 @@ bool MemorizeMessage(const CTransaction &tx, double dAmount, std::string sRecipi
fMessageLoaded = true;
}

WriteCache(sMessageType,sMessageKey+";TrxID",tx.GetHash().GetHex(),nTime);
if(fDebug)
WriteCache("TrxID;"+sMessageType,sMessageKey,tx.GetHash().GetHex(),nTime);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this i was thinking of the same. putting that in front.

@tomasbrod tomasbrod mentioned this pull request Oct 22, 2017
@denravonska denravonska merged commit c80dcf8 into gridcoin-community:development Oct 25, 2017
@Mercosity
Copy link

Looks like we have progress .. Any idea when release will happen?

@tomasbrod
Copy link
Member Author

@Mercosity Only after testing is successful. Testing is currently blocked by #668 Tally improvements unintentional changes breaking pre-mandatory syncing.

@Mercosity
Copy link

Ok @tomasbrod .. Thx for that .. waiting with anticipation ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants