Remove payments CSV export. #759
Conversation
The implementation made it really difficult to reorganize to a new chain as the payments would have to be cut out from a concatenated string. The information is still in the chain but those who wants to export the data to CSV will have to traverse the chain manually.
| // it until it's used. | ||
| std::string sReserved; | ||
| READWRITE(sReserved); | ||
| std::string dummy; |
There was a problem hiding this comment.
Better way of doing this? :( Fiddled with this before. We could serialize based on block version but that removes the backward compatibility (as in when downgrading).
There was a problem hiding this comment.
It is very difficult to work with the IMPLEMENT_SERIALIZE and READWRITE macros. The underlying template code is nice.
Maybe these could be modified or broken down into separate read and write and then go with conditions.
There was a problem hiding this comment.
Yeah, I was thinking something like:
if(nVersion < 9) {
// Read/write obsolete GRC address and reserved string
std::string dummy;
READWRITE(dummy); // Address
READWRITE(dummy); // Reserved string
}
This will fail when downgrading if you have a chain written by a new client.
| //printf(" {CPIDs Re-Loaded} "); | ||
| msNeuralResponse=""; | ||
| } | ||
| msNeuralResponse.clear(); |
There was a problem hiding this comment.
why you removed the barackets?
There was a problem hiding this comment.
Because one-line brackets feel too fluffy :)
| @@ -5247,11 +5229,6 @@ void AddResearchMagnitude(CBlockIndex* pIndex) | |||
| stMag.interestPayments += pIndex->nInterestSubsidy; | |||
|
|
|||
| AdjustTimestamps(stMag,pIndex->nTime, pIndex->nResearchSubsidy); | |||
| // Track detailed payments made to each CPID | |||
| stMag.PaymentTimestamps += ToString(pIndex->nTime) + ","; | |||
| stMag.PaymentAmountsResearch += RoundToString(pIndex->nResearchSubsidy,2) + ","; | |||
There was a problem hiding this comment.
Are you sure this field is not needed for the reward calculation?
There was a problem hiding this comment.
Yeah, it wouldn't build otherwise as the fields were removed from the struct as well.
The implementation made it really difficult to reorganize to a new chain as the payments would have to be cut out from a concatenated string, see #756. The information is still in the chain but those who wants to export the data to CSV will have to traverse the chain manually.