Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page for templates routes break #799

Closed
yaminncco opened this issue Nov 6, 2019 · 3 comments
Closed

404 page for templates routes break #799

yaminncco opened this issue Nov 6, 2019 · 3 comments

Comments

@yaminncco
Copy link

Description

this happen at gridsome.org too, if you visit for example: https://gridsome.org/starters/fsdqs the 404 page seems to work fine, but with multiple errors in the console which break the page functionality (using the search or switching theme)

Steps to reproduce

visit https://gridsome.org/starters/fsdqs
check the console

@hacknug
Copy link
Member

hacknug commented Nov 7, 2019

This is more of an issue for https://github.com/gridsome/gridsome.org than core. It's due to one of those components assuming some things will be available when they're not in 404 pages.

You can see how this other 404 works just fine: https://gridsome.org/blog/ffdsfdfdfsds

@zacnomore
Copy link

Moved to gridsome/gridsome.org#353

@adamJLev
Copy link

No, I would say this is actually a bug in gridsome. Same thing is happening on my site and others, if you happen to have a Route registered for that route - and it 404's, there will be errors on the 404 page - Basically its like the 404.vue file is loaded, but also the target Template component:
gridsome/gridsome.org#353 (comment)

Please reopen this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants