Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No fingerprints assets - Netlify and cache busting urls #840

Merged
merged 5 commits into from Nov 29, 2019

Conversation

igk1972
Copy link

@igk1972 igk1972 commented Nov 27, 2019

This pull request adding the config option for disable the fingerprints in files. The files are obtained without changes.
PR no effective without PR #839

This is very necessary when the site has tens of thousands of HTML pages and as many json files.
Deployment time exceeds half an hour or more.

Netlfy_deploy

For support hosting like Netlify.
https://www.netlify.com/blog/2017/02/23/better-living-through-caching/

Netlify processes every new file. It takes a lot of time.
Fingerprints are not needed for Netlify. The service runs on information in etag.
Also see gatsbyjs/gatsby#11961 (comment)

Probably not everyone needs this feature. But pull request allows now to solve the problem of deploying large sites on Netlify.

Gatsby has the same problems.
gatsbyjs/gatsby#11961

@hjvedvik
Copy link
Member

Thanks! I can review your PRs tomorrow :)

@igk1972
Copy link
Author

igk1972 commented Nov 27, 2019

Related #584

@igk1972
Copy link
Author

igk1972 commented Nov 27, 2019

PR no effective without PR #839

@hjvedvik
Copy link
Member

Thanks again for a good PR @igk1972 :) I have just one question. Can the option be urlFingerprints: false instead? We are trying to have a pattern for options where false will disable a default behavior.

@hjvedvik
Copy link
Member

Or maybe cacheBusting: false because the JSON files actually have the hash inside the content instead of the URL. But it might not matter much :)

@igk1972
Copy link
Author

igk1972 commented Nov 28, 2019

It is not so important.

Make (change) an option at your discretion, as you consider it better.

@igk1972
Copy link
Author

igk1972 commented Nov 28, 2019

cacheBusting is good :)

@hjvedvik
Copy link
Member

Okay, then rename it to cacheBusting which defaults to true for the current behavior :)

@igk1972
Copy link
Author

igk1972 commented Nov 29, 2019

I did as needed, added a commit

@hjvedvik
Copy link
Member

Thank you @igk1972 :)

@hjvedvik hjvedvik merged commit 6765782 into gridsome:master Nov 29, 2019
@hacknug
Copy link
Member

hacknug commented Feb 2, 2020

@hjvedvik any chance we can get something like this working for pages too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants