[Bug]: PS1 incorrectly uses "JAVAARGS" variable name where "JAVA_ARGS" is used for variables.txt

[Frontear]

What happened?

Essentially, the PS1 has a typo that is trying to source the "JAVAARGS" variable from the variables.txt file. This is invalid since by default, the variables.txt file has a "JAVA_ARGS".

The suspecting file can be found here:

ServerPackCreator/serverpackcreator-api/src/jvmMain/resources/de/griefed/resources/server_files/default_template.ps1

Line 24 in dc01430

$JavaArgs = $ExternalVariables['JAVAARGS']

It should be noted that the shell file uses the correct variable, solidifying this as a simple typo. Nothing major but it does break PS1 for windows users.

Line in shell confirming the correct variable:

ServerPackCreator/serverpackcreator-api/src/jvmMain/resources/de/griefed/resources/server_files/default_template.sh

Line 70 in dc01430

SERVER_RUN_COMMAND="-Dlog4j2.formatMsgNoLookups=true ${JAVA_ARGS} -jar ${LAUNCHER_JAR_LOCATION} nogui"

What did you expect to happen?

Well, I expected it to source the right variable

Version

Release 4.1.2

Relevant log output

No response

Anything else you would like to add?

No response

If you are using the webservice, in which browers did you encounter this bug?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[Griefed]

Heya Frontear,

thanks for the report. I'll fix this asap! 😊

Cheers,
Griefed

[Griefed]

Also a huge thanks for the detailed report!

[Griefed]

Fixed in 4.1.3 😊