Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Create eula.txt with eula=true #83

Closed
Griefed opened this issue Oct 4, 2021 · 5 comments
Closed

Feature request: Create eula.txt with eula=true #83

Griefed opened this issue Oct 4, 2021 · 5 comments
Assignees
Labels
accepted Feature Ask which got accepted. enhancement New feature, request or improvement

Comments

@Griefed
Copy link
Owner

Griefed commented Oct 4, 2021

  • What is the current behavior?

Using a server pack generated by ServerPackCreator still requires the admin to set eula=true in the eula.txt which is generated when the server is started for the first time.

  • What is the wanted/requested behavior?

Have ServerPackCreator generate a eula.txt containing

#By changing the setting below to TRUE you are indicating your agreement to our EULA (https://account.mojang.com/documents/minecraft_eula).
#Mon Oct 04 18:09:13 CEST 2021
eula=true

in the generated server pack so the admin can fire and forget their servers after uploading them to their servers.

  • What are your reasons for making this feature request? Provide solid arguments on why I should start working on it.
    Starting the server for the first time, only to have it stop because the eula.txt was generated, then having to set eula=true and starting the server again can become a chore and minor annoyance. Having this feature would make using server packs generated by ServerPackCreator nicer to use and also make running test server packs a little nicer.
@Griefed Griefed added the enhancement New feature, request or improvement label Oct 4, 2021
@Griefed Griefed self-assigned this Oct 4, 2021
@Griefed Griefed added this to To do in Issue Tracker via automation Oct 4, 2021
@Griefed
Copy link
Owner Author

Griefed commented Oct 4, 2021

The start-scripts generated by ServerPackCreator should also check for a eula.txt, as proposed by @kreezxil in #81 (comment)

@Griefed
Copy link
Owner Author

Griefed commented Oct 4, 2021

Will be available in the next alpha release.

@Griefed Griefed closed this as completed Oct 4, 2021
Issue Tracker automation moved this from To do to Done Oct 4, 2021
Griefed added a commit that referenced this issue Oct 15, 2021
…e request issue #83. Lots of other smaller things, too many to list.
@Griefed
Copy link
Owner Author

Griefed commented Oct 16, 2021

Reopened:

  1. Check whether eula.txt exists.

  2. If it does not:
    2.1 print

    Mojang's EULA has not yet been accepted. In order to run a Minecraft server, you must accept Mojang's EULA.
    Type "I agree" to indicate that you agree to Mojang's EULA.
    Mojang's EULA is available to read at https://account.mojang.com/documents/minecraft_eula

    2.2 if user specified "I agree"
    write eula=true into eula.txt, else do nothin' and let the modloader yell at them that they need to agree to the EULA.

@Griefed Griefed reopened this Oct 16, 2021
Issue Tracker automation moved this from Done to In progress Oct 16, 2021
@Griefed Griefed changed the title Feature: Create eula.txt with eula=true Feature request: Create eula.txt with eula=true Oct 17, 2021
@Griefed
Copy link
Owner Author

Griefed commented Nov 24, 2021

Will be available in the next alpha release.

@Griefed Griefed closed this as completed Nov 24, 2021
Issue Tracker automation moved this from In progress to Done Nov 24, 2021
@Griefed
Copy link
Owner Author

Griefed commented Nov 26, 2021

@Griefed Griefed added the accepted Feature Ask which got accepted. label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Feature Ask which got accepted. enhancement New feature, request or improvement
Projects
No open projects
Issue Tracker
  
Done
Development

No branches or pull requests

1 participant