Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use context instead of mergeContext #18

Open
strmer15 opened this issue Feb 28, 2020 · 4 comments
Open

Use context instead of mergeContext #18

strmer15 opened this issue Feb 28, 2020 · 4 comments

Comments

@strmer15
Copy link

Getting this warning when doing soft deletes:

`QueryBuilder#mergeContext` method is deprecated. The `context` method now behaves just like `mergeContext`. `mergeContext` method will be removed in 3.0

Please change uses of mergeContext to context to remove these warnings.

@adprajwol
Copy link

Any updates on this?

@alex-w0
Copy link

alex-w0 commented Oct 19, 2020

Is this plugin still maintained? Last update was 2019...

@alex-w0
Copy link

alex-w0 commented Oct 31, 2020

@adprajwol @strmer15 Hi guys, due to the inactivity of the author I've rewritten the package. Check out this package if you wanna get rid of this annoying message: https://github.com/alex-w0/objection-js-soft-delete#readme

@andrucz
Copy link

andrucz commented Sep 14, 2022

@alex-w0 unfortunately I wasn't able to make your plugin work due to that issue with TypeScript.

I was able to make this plugin work with Objection.js v3 after adding this line to the app initialization:

QueryBuilder.prototype.mergeContext = QueryBuilder.prototype.context;

https://vincit.github.io/objection.js/release-notes/migration.html#context-now-acts-like-mergecontext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants