Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Current state for ACC 1.0 #11

Open
8 of 10 tasks
grimsi opened this issue May 27, 2019 · 25 comments
Open
8 of 10 tasks

[Misc] Current state for ACC 1.0 #11

grimsi opened this issue May 27, 2019 · 25 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@grimsi
Copy link
Owner

grimsi commented May 27, 2019

  • support new tracks (thanks @surtic86)
  • support racecraft rating requirement (thanks again @surtic86)
  • support competition rating (not necessary)
  • limit server slots depending on safety rating settings
  • implement support for entry lists (huge feature, will likely take longer):
  • entry list support backend (currently not 100% tested)
  • entry list support frontend
  • implement support for teams + driver swaps (done with entry lists)
  • implement support for spectator slots + spectator password (thanks @surtic86)
  • implement support for the broadcasting API if needed (not needed)
  • implement support for locking server during race
@grimsi grimsi self-assigned this May 30, 2019
@grimsi grimsi added the enhancement New feature or request label May 30, 2019
@grimsi grimsi added this to Backlog in AC Competizione Server Manager via automation May 30, 2019
@grimsi grimsi added this to the 1.1.0 milestone May 30, 2019
@cheesegrits
Copy link

Could you get the new tracks in as a quickie, before moving on to the harder stuff?

If I specify a junk track name, the err log spits out this, which I assume is all the supported names.

==ERR: 'monza'
==ERR: 'brands_hatch'
==ERR: 'spa'
==ERR: 'misano'
==ERR: 'paul_ricard'
==ERR: 'zolder'
==ERR: 'silverstone'
==ERR: 'hungaroring'
==ERR: 'nurburgring'
==ERR: 'barcelona'

@CptChaos
Copy link

CptChaos commented May 30, 2019

@cheesegrits It seems like there's more to be done than just the tracks. I can't seem to get a server running, wine starts in a defunct state (or at least ps aux | grep wine tells me that after I opened bash on the container) for some reason here, and I had a clean install of the VM where it's all running in (started playing since official release). Using latest version of Docker (CE) in a freslhy installed Debian 9 VM. And yes, the user which runs accservermanager is added to the group for docker, so it should be capable to do anything Docker related as well.

@surtic86
Copy link

I made a first Pull Requests for the Tracks: #15

For other things i need to look more into the Code first and get it setup right for Testing and all. Can you eventually make a short Setup Readme for Developers? How to Build the Frontend into Backend and so on?

@grimsi grimsi assigned grimsi and unassigned grimsi May 31, 2019
@surtic86
Copy link

support racecraft rating requirement (thanks again @surtic86)

Not yet complete Supported. Im working right now in the Frontend on it. But Pull Request will come son on the Repo as soon as get the Jar Building ;)

@grimsi
Copy link
Owner Author

grimsi commented May 31, 2019

Awesome. I will take a look at the other stuff on the weekend if you need any help just send me an email or something

@surtic86
Copy link

spectator don #19

@surtic86
Copy link

surtic86 commented May 31, 2019

do you want to open separated issues / feature request for the bigger features?

also i havn't found any default settings for entry lists, teams and competition rating. looks like they are still working on some stuff before they release the Doc https://www.assettocorsa.net/forum/index.php?threads/0-6-multiplayer-server-configuration-for-server-admins.54830/page-17#post-1055663

@surtic86
Copy link

surtic86 commented Jun 8, 2019

New Server Params: "isRaceLocked" so no one can Join when the Race is running https://www.assettocorsa.net/forum/index.php?threads/public-beta-1-0-2-build-3898406.58119/

@grimsi
Copy link
Owner Author

grimsi commented Jun 8, 2019

Good spot!
I find it really irritating that there is no official documentation yet because I would have time to code this weekend...
Unfortunately it will take a few days bc they want to fix all their bugs first

@cheesegrits
Copy link

cheesegrits commented Jun 9, 2019

@grimsi If it gives you something to do, here's an example of an entrylist.json Kevin from Kunos shared with me (and gave permission to share on).

{
    "entries": [
        {
          "drivers": [
            {
              "firstName": "Number",
              "lastName": "One",
              "shortName": "NOO",
              "nationality": 1,
              "driverCategory": 2,
              "helmetTemplateKey": 500,
              "helmetBaseColor": 0,
              "helmetDetailColor": 0,
              "helmetMaterialType": 0,
              "helmetGlassColor": 0,
              "helmetGlassMetallic": 0.0,
              "glovesTemplateKey": 2,
              "suitTemplateKey": 500,
              "suitDetailColor1": 40,
              "suitDetailColor2": 160,
              "playerID": "S123456"
            },
            {
              "firstName": "Kevin",
              "lastName": "Someone",
              "shortName": "KST",
              "nationality": 1,
              "driverCategory": 2,
              "helmetTemplateKey": 500,
              "helmetBaseColor": 0,
              "helmetDetailColor": 0,
              "helmetMaterialType": 0,
              "helmetGlassColor": 0,
              "helmetGlassMetallic": 0.0,
              "glovesTemplateKey": 2,
              "suitTemplateKey": 500,
              "suitDetailColor1": 40,
              "suitDetailColor2": 160,
              "playerID": "S654321"
            }
          ],
            "customCar": "",
            "raceNumber": 88,
            "defaultGridPosition": -1,
            "forcedCarModel": -1,
            "overrideDriverInfo": 1,
            "isServerAdmin": 1,
            "configVersion": 0
        }
    ],
    "configVersion": 1
}

He added ...

it has many options, but the absolutely important line is the playerID - there goes "S" + steamid
so the whole thing can be stripped down to

{
    "entries": [
        {
          "drivers": [
            {
              "playerID": "S123456"
            }
          ],
            "raceNumber": 88,
            "forcedCarModel": -1,
            "overrideDriverInfo": 1,
            "isServerAdmin": 1,
        }
    ]
}

@cheesegrits
Copy link

(Kevin is working on an admin document, hopes to have it ready soon)

@grimsi
Copy link
Owner Author

grimsi commented Jun 9, 2019

Thanks a lot!
I will start working on it (although the final release has to wait until we have an official documentation anyway).

@surtic86
Copy link

surtic86 commented Jun 9, 2019

Good thing it looks like with the Entry List you have also don Teams and Driver Swap Implementation.

  • implement support for entry lists (huge feature, will likely take longer)
  • implement support for teams + driver swaps

@grimsi
Copy link
Owner Author

grimsi commented Jun 9, 2019

Doesn't look like the entry list contains the parameters for teams and driver swaps all I can see is different car skins and colors but no team assignment

@cheesegrits
Copy link

cheesegrits commented Jun 10, 2019

Well, that example has two drivers (NOO and KST) for a single entry, which is how you enable swaps. So 'entries' is an array of objects, then within each entry object is a 'drivers' array of driver objects.

@cheesegrits
Copy link

The other thing Kevin shared with me was in settings.json you can now have ...

"dumpLeaderboards": 1,

... which, if there is a ./results folder, should dump results. I haven't tested it yet.

I can't remember if I mentioned, but I do server admin for a league (ACRL), and we've been evaluating ACC in our off weeks in the current AC based GT3 season, to decide if it's ready for league use yet. Short answer is "not yet", but I reckon a few more bug fix and minor feature releases and it should be. And I'm very interested in using accservermanager as part of our league provisioning. We typically have about 100 drivers in a GT3 season, so pre-quali, entry lists for server splits and result handling get quite complex. We currently have provisioning built in C#and Rust. I'm busy dealing with AC stuff for our current season atm, but as soon as we start the serious planning for our first ACC season, I'd be happy to start helping out with any work you need doing on accservermanager.

@grimsi
Copy link
Owner Author

grimsi commented Jun 10, 2019

You're both right, I viewed this issue on my phone and didn't realize that drivers is an array. That certainly makes things easier.
Implementing entry lists in the backend is trivial, but the frontend may take a while (especially if done right. I have a few ideas like searching for Steam names instead of entering Steam IDs or having a color picker instead of entering the color codes).

If you want to use my software for your league we can talk via DM. I guess you would need a few extra features that the server manager currently does not offer, but I have no problem implementing them.
Only problem is that my time is currently limited since I have exams at the end of the month and after that I have to write my bachelors thesis which means that I cant really commit to anything right now. But I will do as much as I can

@grimsi
Copy link
Owner Author

grimsi commented Jun 10, 2019

Kunos just released an official documentation 🎉

https://www.assettocorsa.net/forum/index.php?threads/the-server-admin-handbook-thread.58245/

ServerAdminHandbook_v1.pdf

@surtic86
Copy link

surtic86 commented Jun 10, 2019

Uh i see you have a lot don today! Thanks

@GazCBG
Copy link

GazCBG commented Jun 14, 2019

When do you think the new tracks will be added?

@grimsi
Copy link
Owner Author

grimsi commented Jun 16, 2019

The new tracks are already added thanks to @surtic86

However the other stuff will most likely take a while

@CptChaos
Copy link

CptChaos commented Jul 4, 2019

Not sure where to put it, but since the release of 1.0.5 today there's a new version of the handbook out.
See attachment ServerAdminHandbook_v2.pdf.

@grimsi
Copy link
Owner Author

grimsi commented Jul 4, 2019 via email

@CptChaos
Copy link

CptChaos commented Aug 10, 2019

And version 3 of the ServerAdminHandbook has been released, I took the liberty to upload it so you don't have to search for it. ;)
I hope your exams went good and that you enjoy a well deserved holiday now!

@CptChaos
Copy link

CptChaos commented Nov 2, 2019

ServerAdminHandbook_v5.pdf

In the mean time, version 5 has been released. Since version 3 the handbooks are also packed in the folder where you can find accServer.exe. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

5 participants