feat(download): add file size calculation for DownloadService #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimsi
requested changes
Oct 19, 2022
backend/src/main/java/de/grimsi/gameyfin/service/DownloadService.java
Outdated
Show resolved
Hide resolved
|
Thanks a lot for your contribution! |
This allows the browser to show file size and a time estimate for downloading files. Does not work for ZipOutputStreams though since dir size doesn't match the zip file size. Also added no-cache headers so browser won't start caching downloads.
Happy to contribute! I really like the interface of GameyFin and since I'm a Java dev I decided to add this myself instead of opening feature requests and create more work for you. 👍 I'll probably open a few more PRs in the future! 😄 |
grimsi
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the browser to show file size and a time estimate for downloading files.
Does not work for ZipOutputStreams though since dir size doesn't match the zip file size.
Also added no-cache headers so browser won't start caching downloads.