Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #60

Merged
merged 20 commits into from
Oct 21, 2022
Merged

Improve test coverage #60

merged 20 commits into from
Oct 21, 2022

Conversation

grimsi
Copy link
Member

@grimsi grimsi commented Oct 21, 2022

No description provided.

grimsi and others added 19 commits October 16, 2022 01:05
This allows the browser to show file size and a time estimate for downloading files.
Does not work for ZipOutputStreams though since dir size doesn't match the zip file size.
Also added no-cache headers so browser won't start caching downloads.
fix(game-detail): prevent overflow of long company logos
feat(refresh): added refresh button on game detail view to refresh metadata
feat(download): add file size calculation for DownloadService
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@grimsi grimsi marked this pull request as ready for review October 21, 2022 16:51
@grimsi grimsi changed the base branch from release-1.2.4 to main October 21, 2022 16:51
@grimsi grimsi merged commit 910b467 into main Oct 21, 2022
@grimsi grimsi deleted the gh33_ImproveTestCoverage branch October 21, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants