Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fnav links broken for titles with single quotes. #4

Closed
ceylon23 opened this issue Dec 8, 2013 · 1 comment
Closed

fnav links broken for titles with single quotes. #4

ceylon23 opened this issue Dec 8, 2013 · 1 comment

Comments

@ceylon23
Copy link
Contributor

ceylon23 commented Dec 8, 2013

I've noticed that single quotes are not being escaped and are creating attribute closures thereby creating broken click events for fnav. I see that the links themselves are based on the title of the article. Maybe adding an identifier tag to each post and linking to those could be a possible solution.

@grmmph
Copy link
Owner

grmmph commented Dec 8, 2013

Yes, that is correct. This is a required change to avoid broken links on special characters.
Not sure when I will have the time to make that change, but in the meantime if you feel like fixing it yourself it would be very much appreciated.

@grmmph grmmph closed this as completed Dec 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants