Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please state the minimum required PHP version #166

Closed
asmfreak opened this issue Mar 7, 2019 · 1 comment
Closed

Please state the minimum required PHP version #166

asmfreak opened this issue Mar 7, 2019 · 1 comment
Labels

Comments

@asmfreak
Copy link

asmfreak commented Mar 7, 2019

I can confirm grocy does not work with PHP 7.0 because of some dependencies, namely Tuupola\Middleware\CorsMiddleware which requires at least 7.1 see ( this comment )

@berrnd berrnd added the question label Mar 7, 2019
@berrnd
Copy link
Member

berrnd commented Mar 7, 2019

Right, we also had this in #8 and #53.

It's stated in README that currently everything is only tested against PHP 7.2:
https://github.com/grocy/grocy#how-to-install

I personally don't see a problem with this and don't want to "optimize" anything by not using never PHP features - having multiple versions of PHP on the same machine is not a real problem, when needed, in my opinion. Also I would say the larger number of users are running grocy with grocy-docker (me not included), which uses PHP 7.2 anyway...

@berrnd berrnd closed this as completed Mar 7, 2019
@berrnd berrnd mentioned this issue Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants