Bug: "n products are overdue"-status header on /stockoverview also includes stock entries due today or tomorrow

[Janovlk]

Hello,

the grey "# products are overdue" header now behaves differently than before. Seemingly it counts expired products (which is logical) plus products due today (in example from the demo version I added the product Milk which is due today) plus a products which are due in a day. Now there is a discrepancy in color coding of products. This new algorithm is misleading me. I can imagine it can be beneficiary for some users if it would be optional.

PP

[berrnd]

Please create a private demo instance if you want to provide a reproducible example, the public instances are used by hundreds of people daily and get therefore also reseted multiple times a day - it's impossible to share scenarios there persistently.

[berrnd]

now behaves differently than before

Would be cool if you could specify what "before" refers to exactly.

 

the grey "# products are overdue" header now behaves differently than before. Seemingly it counts expired products (which is logical) plus products due today

Of course this makes no sense and any intended change is, as always, documented on the changelog. Is reproducible, will be fixed for the next release.

[Janovlk]

Hello,

okay, I created it in a Private Demo: https://test-42cvxut103tkp0ra9zwp9m.demo-prerelease.grocy.info/stockoverview
It behaves the same as well as my 4.0.3 production version on my server. In version 4.0.2 and lower it didn't behave like this, more logical and it was consistent with color coding of products in Product Overview page.

[berrnd]

In version 4.0.2 and lower it didn't behave like this

Can't be true. It's caused by using PHP 8.1 or 8.2, which is a requirement and only supported since Grocy v4.0.0 - means this problem first occurred in Grocy v4.0.0, not v4.0.2.