Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion - Update typography to use rem #364

Open
3 tasks
taysea opened this issue Jul 20, 2023 · 0 comments
Open
3 tasks

Discussion - Update typography to use rem #364

taysea opened this issue Jul 20, 2023 · 0 comments
Labels
discussion

Comments

@taysea
Copy link
Collaborator

taysea commented Jul 20, 2023

Update typography to use rem to leverage browser font scaling functionality. With hard coded px values, this behavior is not supported

A couple of things to explore in native html/other component libraries:

  • Should all instances of text scale? For example, should buttons?
  • Test across browsers, try on GLCP, COM, Design System site

Deliverable:

  • PR with changes. Values should resolve to what exists in the theme at the moment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taysea