Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 24-hour time format in Timestamp #1157

Closed
mjasnikovs opened this issue Jan 25, 2017 · 1 comment
Closed

Missing 24-hour time format in Timestamp #1157

mjasnikovs opened this issue Jan 25, 2017 · 1 comment
Assignees

Comments

@mjasnikovs
Copy link

mjasnikovs commented Jan 25, 2017

Missing 24-hour time format in Timestamp. 12-hour clock is generally used in British colonies.
Globally, required all functionality witch is available in toLocaleDateString. To format time properly accordingly to local standards.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleDateString

@tracybarmore tracybarmore added the needs attention To alert grommet team that a PR has been waiting for the author for a while label Jan 25, 2017
@dgennetten dgennetten self-assigned this Apr 10, 2017
@dgennetten dgennetten removed their assignment May 8, 2017
@dgennetten
Copy link
Contributor

@mjasnikovs, as indicated in the link you provided, the Date object (which Timestamp uses) provides 24-hour time format as a default in locales where that is standard. I just verified this is true noting that https://grommet.github.io/docs/timestamp shows "15" for operating in es-ES (Spain), where in the US ('en-US') it shows "10 am".

@dgennetten dgennetten added the in progress Currently in development label May 10, 2017
@dgennetten dgennetten self-assigned this May 10, 2017
@dgennetten dgennetten removed the in progress Currently in development label May 11, 2017
@tracybarmore tracybarmore removed the needs attention To alert grommet team that a PR has been waiting for the author for a while label May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants