Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar component should show days of the week along the top. #2919

Closed
punkscience opened this issue Mar 13, 2019 · 3 comments · Fixed by #2941
Closed

Calendar component should show days of the week along the top. #2919

punkscience opened this issue Mar 13, 2019 · 3 comments · Fixed by #2941
Assignees
Labels
enhancement A suggestion to add to or change behavior

Comments

@punkscience
Copy link

Expected Behavior

As with most desktop calendar widgets, the calendar component should have a row for the day of the week along the top so that a user can tell at a glance that the 1st falls on a Monday, for example. It also communicates to the user whether the calendar begins on Sunday or Monday.

Actual Behavior

There is no day of the week bar, so a user cannot tell what "next tuesday" is without looking at another calendar to compare.

URL, screen shot, or Codepen exhibiting the issue

Is this:

image

Should have the M T W T F S S bar.

: image

Steps to Reproduce

Use the Calendar widget.

Your Environment

  • Grommet version: 2.5.5
  • Browser Name and version: Latest Chrome
  • Operating System and version (desktop or mobile): MacOS 10.14.2
@oorestisime oorestisime added the enhancement A suggestion to add to or change behavior label Mar 13, 2019
@oorestisime
Copy link
Collaborator

So one thing i haven't thought about is i18n!
I think this could actually be a pattern instead of adding the functionality.
@ShimiSun thoughts?

@ShimiSun
Copy link
Collaborator

I think I was able to workaround the i18n issue, check out my PR @oorestisime

@L0ZZI
Copy link
Contributor

L0ZZI commented Mar 20, 2019

Sorry for the late reply but it's always been in the https://github.com/grommet/design-kit 😉. So I tend to agree with the issue. Glad it's fixed.

Calendar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggestion to add to or change behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants