Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Moving RangeInput or RangeSelector on Chrome for Android triggers swipe-to-go-back/forward #3518

Closed
skoshy opened this issue Oct 31, 2019 · 1 comment
Labels
bug issue that does not match design or documentation and requires code changes to address hacktoberfest PRs submitted in October (open-source celebration month)

Comments

@skoshy
Copy link
Contributor

skoshy commented Oct 31, 2019

Expected Behavior

You should be able to swipe on RangeInputs and RangeSelectors without triggering any side effects.

Actual Behavior

Swiping on them triggers the back button or forward gestures on Chrome for Android.

URL, screen shot, or Codepen exhibiting the issue

See the official RangeInput Codesandbox
https://codesandbox.io/s/github/grommet/grommet-sandbox?initialpath=rangeinput&module=%2Fsrc%2FRangeInput.js

20191031_123632

Steps to Reproduce

Try swiping on a RangeInput or RangeSelector on Chrome Mobile with swipe gestures turned on.

Your Environment

Samsung Galaxy S10

Potential Solution

I was able to make a small modification to fix the issue - see this Codesandbox. I wrapped the RangeInput with a div with a passive event handler on it (sources for further reading: [1], [2])

Ideal version would be to do this on the input itself instead of a container div.

@skoshy skoshy changed the title Moving RangeInput or RangeSelector on Chrome for Android triggers swipe-to-go-back/forward Bug: Moving RangeInput or RangeSelector on Chrome for Android triggers swipe-to-go-back/forward Oct 31, 2019
@ShimiSun ShimiSun added bug issue that does not match design or documentation and requires code changes to address hacktoberfest PRs submitted in October (open-source celebration month) labels Sep 22, 2020
@jcfilben
Copy link
Collaborator

I'm no longer seeing this issue (using v2.19.1 of Grommet) I tested on my android device and was able to swipe on RangeInput and RangeSelector without triggering the back/forward behavior on the browser.
Related to #5139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issue that does not match design or documentation and requires code changes to address hacktoberfest PRs submitted in October (open-source celebration month)
Projects
None yet
Development

No branches or pull requests

3 participants